mbstring: move mb_internal_encoding to INI section #19663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the usage of mb_internal_encoding to INI section
jorgsowa
requested review from
bukka,
alexdowad and
youkidearitai
as code owners
jorgsowa
changed the title
|
LGTM |
Girgias
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the usage of
mb_internal_encoding()to INI section for the tests not testing the encoding/function itself, but the other mbstring/iconv functions.I'm aware of other tests where
mb_internal_encoding()is still used to change encoding, but I want to tackle it in another PR.