Fix deoptimization after exit during inc/dec #19680
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-19669
When the assumption that
(PRE|POST)_(INC|DEC)
overflows turns out to be false and we exit, effects are lost if op1 or result were in regs.Fix by updating the stack map before creating the exit point.
My understanding is the stack map is setup for exits to the same opline, but not for exits to the next opline (e.g.
ZREG_LAST_USE
entries are removed byzend_jit_trace_cleanup_stack
). Therefore, we need manual stack map manipulations before creating exit points to the next opline.Analysis of the reproducer:
Opcodes:
T2
inADD T2 CV0($a)
doesn't match type inference, which causes the assertion failure. This is because exiting fromPOST_DEC CV0($a)
didn't updateT2
.