Fix GH-19685: Segfault when bzip2 filter has invalid parameters #19702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Sep 4, 2025
alexandre-daubois
force-pushed
the
stream-append-bz2-failure
branch
from
e6d35d8 to
4c88e07
Compare
devnexen
reviewed
Sep 4, 2025
| @@ -367,6 +367,10 @@ static php_stream_filter *php_bz2_filter_create(const char *filtername, zval *fi | |||
| zend_long blocks = zval_get_long(tmpzval); | |||
| if (blocks < 1 || blocks > 9) { | |||
| php_error_docref(NULL, E_WARNING, "Invalid parameter given for number of blocks to allocate (" ZEND_LONG_FMT ")", blocks); | |||
| pefree(data->strm.next_in, persistent); | |||
There was a problem hiding this comment.
nit: only if you want, on master only maybe, making a goto label to cover the 3 cases.
|
It should be ok in this case but breaking filter chain is sometimes not safe (might cause breaks) so I will need to review it properly - I should be properly looking to filters in 2 or 3 weeks time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19685
When
blocksorworkhave invalid values, it currently let the function execution continue. Instead, we should free some resources and return null to avoid the segfault.