Fix GET_SHELL_CB macro for static builds #19746
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I realize that doing this might make other SAPIs dependent on the cli, and maybe uncommenting it directly is not a good idea. Statically built cli should not use dl, but I don't know how to do it more appropriately. |
|
We should turn this into a draft and open a bug report instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore conditional compilation for GET_SHELL_CB macro to support static builds.
This PR fixes the interactive shell
-anot running with musl-static binaries.EDIT: Oh, I didn't realize this issue only applies to CLI. For other SAPIs, should we use NULL or dlsym directly?