Fix memory leak on failure in phar_convert_to_other() #19755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
approved these changes
Sep 8, 2025
Girgias
reviewed
Sep 8, 2025
Comment on lines
2229
to
+2236
| PHAR_G(last_phar) = NULL; | ||
| PHAR_G(last_phar_name) = PHAR_G(last_alias) = NULL; | ||
|
|
||
| php_stream *tmp_fp = php_stream_fopen_tmpfile(); | ||
| if (tmp_fp == NULL) { | ||
| zend_throw_exception_ex(phar_ce_PharException, 0, "unable to create temporary file"); | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
Do we want to invalidate the cache even in this case?
There was a problem hiding this comment.
I don't think it matters too much, but at least this keeps the current behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by coincidence while looking at #19752
If stream creation fails, we leak all the memory allocated before. If we just move the stream creation upwards we don't need special handling at all.