ext/filter: Check callback validity once #19921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Sep 30, 2025
The call_user_function() API redoes the zend_is_callable() check which has been just done. We can check validity and retrieve the FCC to call it directly rather than having a useless double check
Girgias
force-pushed
the
filter-double-callable-fetch
branch
from
496e7d8 to
14ba46b
Compare
nielsdos
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call_user_function() API redoes the zend_is_callable() check, which has been just done.
We can check validity and retrieve the FCC to call it directly rather than having a useless double check.
This is not planned to be merged before the RC1 cut-off.