Fix GH-19922: gzopen() double free #19924
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Quite interesting. This code was introduced in 9d348ea where it seems that __orig_path was a debug-only field. In that case the old code was likely right. At one point it became a field also outside of debug mode and the code became wrong.
This patch is right as _php_stream_free frees the orig_path field.
| --EXTENSIONS-- | ||
| zlib | ||
| --SKIPIF-- | ||
| <?php |
There was a problem hiding this comment.
This doesn't seem necessary. I think it's fine to remove this skipif.
|
Just for the record I quickly double checked it and this is a correct fix. It's just a debug mode issue but it doesn't hurt to treat it as a normal bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.