Fix --with-openssl-legacy-provider build failure #19927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will try
…________________________________
From: Rasmus Lerdorf ***@***.***>
Sent: Tuesday, September 23, 2025 2:07 AM
To: php/php-src ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [php/php-src] Fix --with-openssl-legacy-provider build failure (PR #19927)
--with-openssl-legacy-provider works ok on the 8.4 branch but needs this include on the master branch to build. It looks like it was just missed in the work on #16918<#16918>
________________________________
You can view, comment on, or merge this pull request online at:
#19927
Commit Summary
* 2e50b17<2e50b17> Fix --with-openssl-legacy-provider build failure
File Changes
(1 file<https://github.com/php/php-src/pull/19927/files>)
* M ext/openssl/openssl_backend_common.c<https://github.com/php/php-src/pull/19927/files#diff-edd9f17531842064c65810403911e72ba190fe75833ba1c05169bb94937d6df0> (4)
Patch Links:
* https://github.com/php/php-src/pull/19927.patch
* https://github.com/php/php-src/pull/19927.diff
—
Reply to this email directly, view it on GitHub<#19927>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BI6J2FRB4DMYNMCEF2I6TTT3UDPSNAVCNFSM6AAAAACHHOFDQWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGQ2DGOBSG4ZTONA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Ah yeah this was somehow unfinished split of the initialization - fixed in #19930 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-openssl-legacy-provider works ok on the 8.4 branch but needs this include on the master branch to build. It looks like it was just missed in the work on #16918