Implement RFC "Deprecate mb_ereg_replace eval option" #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest adding quotes around the |
Good catch, thanks! |
<https://wiki.php.net/rfc/deprecate_mb_ereg_replace_eval_option> has been accepted, so we implement it.
cmb69
force-pushed
the
deprecate_mb_ereg_replace_eval_option
branch
from
e3c9064 to
78b05c7
Compare
|
Had to rebase anyway, so I've squashed the commits. |
|
Merged |
|
😱 I was absolutely sure I had already submitted this. Thanks @cmb69 for picking up the slack 😄 |
|
@realityking No problem. I wish we had some more automation for handling RFCs. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecate_mb_ereg_replace_eval_option has been
accepted, so we implement it.
@realityking Please review. :)