Skip to content

Fix GH-19999: GC refcount assertion failure when destructor modifies variable during concat #20004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-19999: GC refcount assertion failure when destructor modifies variable during concat #20004

wants to merge 2 commits into from

Conversation

alexandre-daubois
Copy link
Member

Fix #19999

@alexandre-daubois alexandre-daubois changed the base branch from master to PHP-8.3 September 30, 2025 08:59
@alexandre-daubois
Copy link
Member Author

I'm not sure it worth a NEWS entry?

@bwoebi
Copy link
Member

bwoebi commented Sep 30, 2025

@alexandre-daubois Any bugfix to a release branch needs a NEWS entry.

@alexandre-daubois
Copy link
Member Author

Preventing the crash is relatively simple, but it causes repeated leaks. I've tried quite a few things, but in the end, it's a game of cat and mouse and doesn't really solve the underlying problem.

Let's close for the reasons exposed here: #19929 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GC Reference Counting Assertion Failure via Object Destruction and Invalid Assignment
2 participants
@alexandre-daubois @bwoebi