Skip to content

MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN #20033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: PHP-8.3
Choose a base branch
from
+9 −3
Open

MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN #20033

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5a62dd
MSVC: Prevent C4005 redefinition warning for WIN32_LEAN_AND_MEAN
wmamrak Oct 1, 2025
adcebfa
Minor NIT.
wmamrak Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion TSRM/TSRM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ typedef uintptr_t tsrm_uintptr_t;

#ifdef TSRM_WIN32
# ifndef TSRM_INCLUDE_FULL_WINDOWS_HEADERS
# define WIN32_LEAN_AND_MEAN
# ifndef WIN32_LEAN_AND_MEAN
# define WIN32_LEAN_AND_MEAN
# endif
# endif
#else
# include <pthread.h>
Expand Down
2 changes: 2 additions & 0 deletions Zend/zend_config.w32.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@
#include <string.h>

#ifndef ZEND_INCLUDE_FULL_WINDOWS_HEADERS
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#endif
#include <winsock2.h>
#include <windows.h>

Expand Down
4 changes: 3 additions & 1 deletion main/php.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@
/* Windows specific defines */
#ifdef PHP_WIN32
# define PHP_PROG_SENDMAIL "Built in mailer"
# define WIN32_LEAN_AND_MEAN
# ifndef WIN32_LEAN_AND_MEAN
# define WIN32_LEAN_AND_MEAN
# endif
# define NOOPENFILE

# include <io.h>
Expand Down
2 changes: 2 additions & 0 deletions win32/syslog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@

#ifndef SYSLOG_H
#define SYSLOG_H
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include <windows.h>

#define LOG_EMERG 1
Expand Down
Loading