Skip to content

Avoid capturing nested arrow function parameters #20041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid capturing nested arrow function parameters #20041

wants to merge 1 commit into from
+46 −1

Conversation

iluuu1994
Copy link
Member

Fixes GH-19867

@iluuu1994 iluuu1994 requested a review from nielsdos October 2, 2025 22:15
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner October 2, 2025 22:15
nielsdos
nielsdos approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right

@staabm
Copy link
Contributor

staabm commented Oct 3, 2025

Do we expect this makes things faster or use less memory?

Can it be measured/compared ?

@iluuu1994
Copy link
Member Author

Do we expect this makes things faster or use less memory?

Not unless you're nesting arrow functions, which should be exceedingly rare.

@iluuu1994 iluuu1994 closed this in 5c956f9 Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@nielsdos nielsdos nielsdos approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine Extension: opcache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly unnecessary binding of variables across arrow functions?
5 participants
@iluuu1994 @staabm @arnaud-lb @nielsdos @Girgias