Zend: Convert certain fields to uint32_t (part 2) #20050
+17
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
compiler-uint32t
branch
2 times, most recently
from
25bc7e8 to
60516ce
Compare
Girgias
force-pushed
the
compiler-uint32t
branch
from
60516ce to
4add438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #19479 as the same rationale applies, these fields are basically already treated like they are
uint32_tso we should type them accordingly.A follow-up PR will be to convert the
default_properties_countCE prop touint32_tbut this requires some changes tozend_object_properties_size()to work properly.