Fix compiler segfault during call compilation #20054
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens due to changes in 28fd759 where the opline opcode may be accessed after the opcode array has been reallocated. To solve this we store the opcode in a temporary variable.
iluuu1994
approved these changes
Oct 3, 2025
staabm
reviewed
Oct 3, 2025
|
|
||
| if (opline->opcode == ZEND_NEW) { | ||
| if (opcode == ZEND_NEW) { | ||
| zend_error_noreturn(E_COMPILE_ERROR, "Cannot create Closure for new expression"); |
There was a problem hiding this comment.
nit: non-PR touched code has wrong indent in this line
There was a problem hiding this comment.
Huh indeed. Good find. I'll fix it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the nightly failure.
Happens due to changes in 28fd759 where the opline opcode may be
accessed after the opcode array has been reallocated.
To solve this we store the opcode in a temporary variable.