Fix GH-16317: SimpleXML does not allow __debugInfo() overrides to work #20131
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work If only we did not have the pseudo-key "@attributes", we could've just removed the custom get_debug_info implementation and this would work out of the box. Anyway, we just have to manually check for an override now.
|
Although a prettier fix is maybe dropping get_debug_info anyway and implementing __debugInfo, although that's also slower of course. 🤷 |
Girgias
reviewed
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only we did not have the pseudo-key "@attributes", we could've just removed the custom get_debug_info implementation and this would work out of the box. Anyway, we just have to manually check for an override now.