phar: Reduce code duplication in destructor #20140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can make a variant of the macro to control the throwing behaviour.
nielsdos
force-pushed
the
phar-duplicated-code-2
branch
from
f009955 to
245c840
Compare
Girgias
approved these changes
Oct 11, 2025
Comment on lines
+4526
to
+4527
| zend_throw_exception_ex(spl_ce_BadMethodCallException, 0, \ | ||
| "Cannot call method on an uninitialized PharFileInfo object"); \ |
There was a problem hiding this comment.
Note for a follow-up PR. This should probably converted to a standard Error exception as all other "attempting to do something on uninitialized object" exceptions
There was a problem hiding this comment.
If we do that we should do an entire pass over ext/phar so it is consistently fixed
There was a problem hiding this comment.
Agreed, which is why this is future scope :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can make a variant of the macro to control the throwing behaviour.