Implement mt_srand_array #2089
Closed
Implement mt_srand_array #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Can you add a tests with negative integers in the seed array as well as positive? It doesn't need to be a long seed array since it's just a portability test. |
Metabolix
force-pushed
the
mt_srand_array-pr
branch
from
55b3f2f to
6ddf754
Compare
|
Modified patch to include negative seed tests. |
The new function mt_srand_array is used to seed the MT19937 PRNG with more than 32 bits. The function takes an array of integers and seeds the PRNG. The seeding procedure is compatible with init_by_array() in mt19937ar.c by MT19937 authors. If an input value cannot be converted to 32-bit integers, a warning will be generated and the PRNG will not be seeded.
Metabolix
force-pushed
the
mt_srand_array-pr
branch
from
6ddf754 to
ca9f010
Compare
|
... and now also fixed that portability. ;) |
|
Thanks for the PR! Supporting "init_by_array()" should be done, IMO, but have you considered to pass the array to mt_srand()? |
|
@Metabolix can we know the status of this PR please ? |
|
Fwiw, I recall the corresponding internals discussion was drawn to a close here. |
|
Ok then, since the author seems to agree with the consensus on internals, that this is not the best solution, I'm closing this PR. Please take this action as encouragement to pursue the solution agreed upon on internals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new function mt_srand_array, as requested in bug 32145. This function will seed the MT19937 PRNG with more than 32 bits, which some people think necessary for statistic calculations. The implementation is compatible with the one provided by the MT authors in their example code.