PHP bug 67130: nextRowset should work with unfetched rows

[peterlebrun]

Bug 67130: Calling nextRowset() with unfetched rows causes a segfault.

I have fixed this by fetching any unfetched rows before advancing the rowset. Attached is a test case.

[nikic]

/cc @adambaratz

[adambaratz]

Thanks for the PR. Could you close this and create a new one against the PHP-7.0 branch? master is 7.2, which is still a ways away from being released. It would be nice to get this fix out sooner.

[nikic]

@adambaratz Unless code has diverged, it's easy to apply PRs to a different branch by wget https://github.com/php/php-src/pull/2134.patch and git am 2134.patch. This is how I usually merge PRs :)

[staabm]

@nikic since a few weeks the person which generated the PR can also do this via webinterface on github.
see https://github.com/blog/2224-change-the-base-branch-of-a-pull-request

[nikic]

@staabm I tried that before (see the history on this PR) -- but this still requires rebasing the changes to a different branch first. Just changing it in the web interface will include all other commits to master in the PR as well ^^

[peterlebrun]

Hi @nikic @adambaratz @staabm

Thank you for considering my PR. I have updated the base branch to PHP-7.0, please let me know if you need anything else.

Peter

[adambaratz]

I merged this successfully via @nikic's method. Thanks all. There's a JS error on the PR tool. I'll close this once it's working again.

[php-pulls]

Comment on behalf of adambaratz at php.net:

Merged into PHP-7.0 and up.

[KalleZ]

@adambaratz if there is a js error then please report it at bugs.php.net :)

[adambaratz]

Was nothing. Just had to clear cache...