Skip to content

Conversation

lt
Copy link
Contributor

@lt lt commented Oct 4, 2016

As per the accepted RFC. mcrypt to be removed in 7.1+1

  • Deleted ext/mcrypt
  • Removed entries from php.ini examples
  • Updated Travis config
  • Removed several references, but deliberately left some in fileinfo/tests and CODING_STANDARDS

@cmb69
Copy link
Member

cmb69 commented Oct 4, 2016

Considering that ext/mcrypt is currently still supported, I'd suggest to move it to PECL (immediately) before removing it from php-src.

@lt
Copy link
Contributor Author

lt commented Oct 4, 2016

Target is master, where (as voted) it is no longer supported.

(That's not to say a PECL repo shouldn't be created, it should, but I cannot do that in this PR :))

@cmb69
Copy link
Member

cmb69 commented Oct 4, 2016

My reasoning is somewhat pessimistic: I'm afraid that as soon as it's removed from master, nobody might care to put it in a PECL repo. :-(

@lt
Copy link
Contributor Author

lt commented Oct 4, 2016

I'll make sure that happens. Lets call this PR on-hold until the PECL is up.

Relevant mailing lists have been contacted. Awaiting feeback.

@lt
Copy link
Contributor Author

lt commented Oct 5, 2016

@CMB https://github.com/lt/pecl-mcrypt

phpize && ./configure && make && make test seems to pass.

Giving internals and pecl-dev an appropriate amount of time to respond to my intentions, and then I'll request a new package repo.

@CMB
Copy link

CMB commented Oct 5, 2016 via email

@cmb69
Copy link
Member

cmb69 commented Oct 5, 2016

People keep confusing me with somebody else apparently.

Sorry! My nick is cmb69…

@lt
Copy link
Contributor Author

lt commented Oct 5, 2016

@CMB Sorry my fault, you'll need to come to Github and click Unsubscribe on this thread now, or you'll keep getting updates.

(I feel your pain, a surprising amount of DSLs use @lt as a "less than" operator)

@krakjoe
Copy link
Member

krakjoe commented Oct 17, 2016

@lt can I get an update on this please (also, fix conflicts if possible) ?

@lt
Copy link
Contributor Author

lt commented Oct 18, 2016

@krakjoe Conflict resolved.

I fired a mail to pecl-dev and internals, there was some brief discussion, some questions unanswered, but I'll go ahead and request PECL access anyway and see what happens.

@krakjoe
Copy link
Member

krakjoe commented Oct 18, 2016

Please can we get some links to internals threads, for future reference.

@cmb69
Copy link
Member

cmb69 commented Oct 18, 2016

Discussion on internals: http://marc.info/?l=php-internals&m=147560034628965&w=2.

@lt
Copy link
Contributor Author

lt commented Oct 29, 2016

@Tyrael Ping. When you get a moment please can you create the php.net hosted git repo like we discussed. Thank you :)

@smalyshev smalyshev added the RFC label Oct 30, 2016
@php-pulls php-pulls merged commit ff8fbf4 into php:master Dec 12, 2016
php-pulls pushed a commit that referenced this pull request Dec 12, 2016
@php-pulls
Copy link

Comment on behalf of leigh at php.net:

Merged in commit 5a17f63

@nikic
Copy link
Member

nikic commented Dec 12, 2016

Needs UPGRADING/NEWS

@krakjoe
Copy link
Member

krakjoe commented Dec 13, 2016

Indeed, @lt is that done ?

@lt
Copy link
Contributor Author

lt commented Dec 13, 2016

Not yet. Will do today.

@lt
Copy link
Contributor Author

lt commented Dec 13, 2016

1da589e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants