-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Remove mcrypt #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mcrypt #2154
Conversation
Considering that ext/mcrypt is currently still supported, I'd suggest to move it to PECL (immediately) before removing it from php-src. |
Target is master, where (as voted) it is no longer supported. (That's not to say a PECL repo shouldn't be created, it should, but I cannot do that in this PR :)) |
My reasoning is somewhat pessimistic: I'm afraid that as soon as it's removed from master, nobody might care to put it in a PECL repo. :-( |
I'll make sure that happens. Lets call this PR on-hold until the PECL is up. Relevant mailing lists have been contacted. Awaiting feeback. |
@CMB https://github.com/lt/pecl-mcrypt
Giving internals and pecl-dev an appropriate amount of time to respond to my intentions, and then I'll request a new package repo. |
Why do I keep getting highlighted on this php-src stuff?
People keep confusing me with somebody else apparently.
|
Sorry! My nick is cmb69… |
@lt can I get an update on this please (also, fix conflicts if possible) ? |
@krakjoe Conflict resolved. I fired a mail to pecl-dev and internals, there was some brief discussion, some questions unanswered, but I'll go ahead and request PECL access anyway and see what happens. |
Please can we get some links to internals threads, for future reference. |
Discussion on internals: http://marc.info/?l=php-internals&m=147560034628965&w=2. |
@Tyrael Ping. When you get a moment please can you create the php.net hosted git repo like we discussed. Thank you :) |
Comment on behalf of leigh at php.net: Merged in commit 5a17f63 |
Needs UPGRADING/NEWS |
Indeed, @lt is that done ? |
Not yet. Will do today. |
As per the accepted RFC. mcrypt to be removed in 7.1+1