Add a "strict_types" key to backtrace output #2177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kinda like this and it makes a lot of sense and should help ease for debugging. Should be fine to commit to 7.2 (master) |
|
Cheers @KalleZ, I'm just firing a mail to internals anyway to make sure I've not overlooked something. |
|
Reviewing failed tests. |
|
@lt bump for status, also links to internals please. |
|
Internals thread: http://markmail.org/message/6ttmg472dqvweqqo |
|
I don't understand how strict types are related to backtrace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to be able to see which functions were called with strict_types enabled or disabled, and where parameters may have had their types converted