Remove (binary) cast from Phar stub #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

kelunik wants to merge 1 commit into php:master from kelunik:phar-binary

Member

kelunik commented Nov 7, 2016

Even if #2187 doesn't get merged (now), there's no reason to use (binary) instead of (string) or nothing at all.


          Remove (binary) cast from Phar stub

e13fa23

Member Author

kelunik commented Nov 7, 2016

Will make a new PR against 7.1.

kelunik closed this

kelunik deleted the phar-binary branch

November 7, 2016 16:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet