Skip to content

Conversation

duncan3dc
Copy link
Member

Added a test for the bug 73538 and also attempted a fix.

The docs say that any call to __setSoapHeaders() will "replace any previous values", so I changed the code to remove the headers, and then add the passed in ones

@KalleZ
Copy link
Member

KalleZ commented Nov 20, 2016

cc @dstogov as he is the soap guy (usually!)

@php-pulls
Copy link

Comment on behalf of krakjoe at php.net:

labelling

@php-pulls php-pulls added the Bug label Nov 20, 2016
ext/soap/soap.c Outdated
} else if (Z_TYPE_P(headers) == IS_ARRAY) {
zval *default_headers;

zend_hash_str_del(Z_OBJPROP_P(this_ptr), "__default_headers", sizeof("__default_headers")-1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line shouldn't be necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I assumed we needed to remove the property before attempting to add one with the same name. I'll remove this line now

@duncan3dc duncan3dc changed the base branch from master to PHP-7.0 November 20, 2016 18:17
@nikic
Copy link
Member

nikic commented Nov 20, 2016

Merged via 685b129, thanks!

@nikic nikic closed this Nov 20, 2016
@duncan3dc duncan3dc deleted the bug73538 branch April 1, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants