Skip to content

Conversation

duncan3dc
Copy link
Member

  • Added a test for Bug 73581
  • Attempted a fix by re-checking if a number is negative after it's been rounded

When negative numbers are rounded to zero they
should not still display the negative sign
@KalleZ
Copy link
Member

KalleZ commented Nov 25, 2016

Seems reasonable tbh, but since it can have edge cast effects you might want to run it by internals, also remember to update UPGRADING since this is most likely to only go in master

@duncan3dc
Copy link
Member Author

Thanks @KalleZ, will do 👍

@php-pulls
Copy link

Comment on behalf of krakjoe at php.net:

labelling

@php-pulls php-pulls added the Bug label Nov 26, 2016
@smalyshev
Copy link
Contributor

I think we need to be very careful in changing number formatting functions. Especially given that many other languages produce the same result: http://news.php.net/php.internals/97186

@krakjoe
Copy link
Member

krakjoe commented Jan 2, 2017

Having read the internals conversation, I'm closing this PR.

We must not deviate from IEEE 754.

@krakjoe krakjoe closed this Jan 2, 2017
@duncan3dc duncan3dc deleted the bug-73581 branch April 1, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants