Fixed #73969 - Fixed segmentation fault when debug_print_backtrace called #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpunt
reviewed
Jan 22, 2017
| } | ||
| if (zend_function_name != NULL) { | ||
| function_name = ZSTR_VAL(zend_function_name); | ||
| } |
There was a problem hiding this comment.
I'd add in an
else {
function_name = NULL;
}
here, to ensure that the function name is NULL if it does not exist (since currently, it could be any garbage). Without it, I get the following output (in debug mode):
#0 c1::() called at [/Users/tpunt/prog/php/tpuntphp/a.php:20]
#1 c1::go() called at [/Users/tpunt/prog/php/tpuntphp/a.php:24]
|
Other than not setting the |
|
Also (note to the merger), this patch belongs in the PHP 7.0 branch as well. |
andrewnester
force-pushed
the
73969-seg-fault-debug_backtrace
branch
from
fc4d5c1 to
542a981
Compare
|
Merged 6f912f7 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=73969