New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #73969 - Fixed segmentation fault when debug_print_backtrace called #2329

Closed
wants to merge 1 commit into
base: PHP-7.0
from

Conversation

3 participants
@andrewnester
Contributor

andrewnester commented Jan 22, 2017

Show outdated Hide outdated Zend/zend_builtin_functions.c Outdated
@tpunt

This comment has been minimized.

Show comment
Hide comment
@tpunt

tpunt Jan 22, 2017

Contributor

Other than not setting the function_name to NULL on failure, this patch LGTM.

Contributor

tpunt commented Jan 22, 2017

Other than not setting the function_name to NULL on failure, this patch LGTM.

@tpunt

This comment has been minimized.

Show comment
Hide comment
@tpunt

tpunt Jan 22, 2017

Contributor

Also (note to the merger), this patch belongs in the PHP 7.0 branch as well.

Contributor

tpunt commented Jan 22, 2017

Also (note to the merger), this patch belongs in the PHP 7.0 branch as well.

@krakjoe krakjoe added the Bugfix label Jan 22, 2017

@andrewnester

This comment has been minimized.

Show comment
Hide comment
@andrewnester

andrewnester Jan 22, 2017

Contributor

@tpunt thanks for comment! I updated PR according to this. @krakjoe I rebased PR to PHP-7.0 branch

Contributor

andrewnester commented Jan 22, 2017

@tpunt thanks for comment! I updated PR according to this. @krakjoe I rebased PR to PHP-7.0 branch

@andrewnester andrewnester changed the base branch from PHP-7.1 to PHP-7.0 Jan 22, 2017

@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 22, 2017

Member

Merged 6f912f7

Thanks.

Member

krakjoe commented Jan 22, 2017

Merged 6f912f7

Thanks.

@krakjoe krakjoe closed this Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment