Remove requirement for authority portion of user stream wrapper URIs #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main/streams/streams.c
Outdated
| PHP_STRLCPY(wrapper_name, protocol, sizeof(wrapper_name), n); | ||
|
|
||
| php_error_docref(NULL, E_WARNING, "Unable to find the wrapper \"%s\" - did you forget to enable it when you configured PHP?", wrapper_name); | ||
| if (path[n+1] == '/' && path[n+2] == '/') { |
There was a problem hiding this comment.
I guess to use strncmp will be better here
main/streams/streams.c
Outdated
| wrapper = NULL; | ||
| protocol = NULL; | ||
| } | ||
| } | ||
| efree(tmp); | ||
| } | ||
|
|
||
| if (wrapper && wrapper->is_uri == 0 && path[n+1] != '/' && path[n+2] != '/') { |
There was a problem hiding this comment.
Thanks for review, I'll use strncmp once then before if statement.
brzuchal
changed the title
|
Just a gentle reminder that the respective RFC is still in draft status. :) |
|
Thanks @cmb69 for friendly reminder I almost forgot about that RFC. Will verify next week if I can revive this. |
|
I decided to withdraw work on this RFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is for PHP RFC: Ommit double-slash in user Stream Wrapper URI.
This patch enable and adjust the code, add phpt.