Bug #73988 (zone offset not recognized by timezone_name_from_abbr) #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrKuporosov
changed the title
|
Changes to timelib are meant to go upstream, I believe. The maintainer of timelib has stated that he doesn't think it makes sense to add this because it's not unique ... I haven't been given grounds to ignore him. @derickr more input please ? |
|
Yes, this change should not go here in the first place. But I haven't heard any good counter arguments as what I wrote in https://bugs.php.net/bug.php?id=73988, so I'm not inclined to accept this PR there either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://bugs.php.net/bug.php?id=73988