Bug #63581 Possible null dereference and buffer overflow #234

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@laruence

This comment has been minimized.

Show comment Hide comment
@laruence

laruence Nov 25, 2012

I think this should be len > FPM_LOG_BUFFER, since you have increase the buf size by 1 byte

I think this should be len > FPM_LOG_BUFFER, since you have increase the buf size by 1 byte

This comment has been minimized.

Show comment Hide comment
@remicollet

remicollet Nov 25, 2012

Owner

If len = FPM_LOG_BUFFER, you don't have place for 1 more char (only place for the final "\n")

Owner

remicollet replied Nov 25, 2012

If len = FPM_LOG_BUFFER, you don't have place for 1 more char (only place for the final "\n")

@remicollet

This comment has been minimized.

Show comment Hide comment
@remicollet

remicollet Nov 28, 2012

Contributor

Applied

Contributor

remicollet commented Nov 28, 2012

Applied

@remicollet remicollet closed this Nov 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment