Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #50892 - Protected members of non-congruent children classes are visible #2388

Closed
wants to merge 1 commit into from

Conversation

4 participants
@pmmaga
Copy link
Contributor

commented Feb 16, 2017

Link for bugsnet: https://bugs.php.net/bug.php?id=50892

This behavior was introduced with a bug fix for a bug stating that the opposite should be true:
https://bugs.php.net/bug.php?id=37212

@marcioAlmada

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2017

=O

@pmmaga

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2017

CI failures seem unrelated.

@krakjoe krakjoe added the Bugfix label Feb 17, 2017

@nikic

This comment has been minimized.

Copy link
Member

commented Feb 17, 2017

I'm afraid that this bug has existed so long that it turned into a feature. I'm pretty apprehensive about making such a major change to visibility handling.

@krakjoe

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

I agree with @nikic, we can't very well make this change in any version currently being developed.

I would suggest it could be made in a major version, which is likely to need a different patch, and a discussion on internals, so I'm closing this PR.

@krakjoe krakjoe closed this Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.