Fix #50892 - Protected members of non-congruent children classes are visible #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
=O |
|
CI failures seem unrelated. |
|
I'm afraid that this bug has existed so long that it turned into a feature. I'm pretty apprehensive about making such a major change to visibility handling. |
|
I agree with @nikic, we can't very well make this change in any version currently being developed. I would suggest it could be made in a major version, which is likely to need a different patch, and a discussion on internals, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link for bugsnet: https://bugs.php.net/bug.php?id=50892
This behavior was introduced with a bug fix for a bug stating that the opposite should be true:
https://bugs.php.net/bug.php?id=37212