Fixed #74099 - Memory leak with openssl_encrypt() #2389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krakjoe seems like CI failure is not related to this fix, could you please confirm? |
nikic
approved these changes
Feb 17, 2017
|
Merged via 15b8b12, thanks! |
|
I have no idea why I added that check. It doesn't make sense to me now. Probably some weird confusion... :) Anyway thanks for fixing that ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bugs.php.net/bug.php?id=74099
Actually changes are following:
(!enc || data_len > 0)was changed to(!enc || data_len >= 0)data_lenis unsigned that's whydata_len >= 0is alwaystrueand condition was removed.