Add warning for change session id when session is active

[dreamsxin]

No description provided.

[nikic]

There are test failures on Travis.

/cc @yohgaki

[yohgaki]

The change is good. I'll look into why travis fails.

[yohgaki]

@dreamsxin
You set invalid char for session ID in ext/session/tests/session_id_error3.phpt. Is the test passed on your system?

[dreamsxin]

@yohgaki
I will fix, In the editor copy invalid char auto change.

[yohgaki]

@dreamsxin
I haven't look into the related code close enough, but IIRC, invalid chars handling is up to save handlers except few chars. All you may have to do is to set appropriate save handler for the test. I guess you are using 3rd party save handler such as memcached.

Invalid chars in session ID is perfectly OK in tests, so you may keep using invalid session ID if you would like. I suggest to use escape sequence in this case.

[dreamsxin]

@yohgaki Help see why fails.

[yohgaki]

@dreamsxin You don't have to discard invalid chars. Set save handler to "files", and adjust expected test script outputs. Since some developers may have problem with invalid chars, it's better to use escape sequence for invalid chars(bytes). e.g. "\x01"

[dreamsxin]

@yohgaki Use hex string? I will replace. But now for the failure now has nothing to do with that.

[dreamsxin]

Already used 16 decimal values instead.

[yohgaki]

@dreamsxin
It seems test is fixed.
I'm not quite sure how you fixed error, but I guess your test was failed because session.c removes some offending chars for session ID embedding in web pages. I'll check your patch fully and merge later. Thank you for your pull request!

[krakjoe]

@yohgaki what is the status of this patch ?

[yohgaki]

@krakjoe
The diff is good to merge. It should prevent changing id, but return current id when name is null. Please merge this.

[krakjoe]

Merged 072ef62

Thanks.