Fixed bug #74300

[xKerman]

fix for https://bugs.php.net/bug.php?id=74300 .

[krakjoe]

var_unserializer.c is generated code, we do not change it directly.

[xKerman]

@krakjoe Thanks, so is it better excluding var_unserializer.c from this pull request?

[xKerman]

Updated pull request not to include var_unserializer.c for diff.

[krakjoe]

Oh sorry, I missed the change to generator input and thought only the generated parser was changed ... this should include the change to the generated parser, and the generator input ...

[xKerman]

Oh, I see, I will include var_unserializer.c for diff.

[xKerman]

Updated (include var_unserializer.c for diff)

[krakjoe]

@smalyshev can I get a thumbs up for this please ?

[nikic]

There's a number of bugs similar to this:

• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L586 Accepts R:-1 and R:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L612 Accepts r:-1 and r:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L790 Accepts o:-1 and o:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L700 Accepts s:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L732 Accepts S:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L766 Accepts a:+1
• https://github.com/xKerman/php-src/blob/0d5dcb635c5f46cd0174613c992dc32a9d3ee5f6/ext/standard/var_unserializer.re#L801 Accepts C:+1 and O:+1

The negative references are allowed by the lexer but will be rejected lateron.

[nikic]

Merged via 6a1d4cd into master. I didn't apply this change to stable branches, because it is technically BC breaking and there is no real problem with continuing to accept this input. (And yes, we had people complain about changes like this before.)

[nikic]

Issued mentioned in the previous comment fixed with 8522e28.

[smalyshev]

@krakjoe Looks fine to me. Agree with @nikic that it is not really required for stable branches, but no reason to keep accepting this further.

[xKerman]

Thanks!