Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 74376 #2454

Merged
merged 1 commit into from Apr 7, 2017

Conversation

3 participants
@pp3345
Copy link
Contributor

commented Apr 5, 2017

This PR fixes bug https://bugs.php.net/bug.php?id=74376

@krakjoe krakjoe added the Bugfix label Apr 6, 2017

@krakjoe

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

This looks okay for 7.0, but 7.1 seems to use different logic, and as far as I can tell, it seems to call mnd_free with the persistent argument.

Could I ask that you verify whether 7.1 requires a patch because the version in the bug report is 7.1.3, not 7.0.

@krakjoe krakjoe self-assigned this Apr 6, 2017

@pp3345

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2017

I can confirm that the bug exists on PHP 7.1, too (and 5.6 btw, though it's security-fixes only by now). The logic in 7.1 looks the same to me and the same patch properly fixes the bug on 7.1.

@php-pulls php-pulls merged commit 27120d4 into php:PHP-7.0 Apr 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.