Fixed bug #74421 Wrong reflection on ReflectionFunction::invoke #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't go into 7.0, because it's BC breaking. We also have a complaint about a similar change on master in bug #74292, so maybe it can't go into master either. |
|
Please start a discussion on internals regarding this change (and any other changes that have same impact), in order to build consensus about what to do here. Please post a link to discussion when started (using externals.io is preferable). |
|
Since we have waited more than a month for action on this pull request, I'm going to assume that the idea is abandoned and close the PR. If I'm wrong about that, please start the requested discussion when opening a new PR. |
|
@carusogabriel This PR has been closed due to the BC break it would cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #74421 but also bug #71416.