Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug #74386 Phar::__construct(): wrong number of parameters by reflection #2512

Closed
wants to merge 1 commit into from

Conversation

2 participants
@villfa
Copy link
Contributor

commented May 6, 2017

No description provided.

@villfa villfa changed the title Fix Bug #74386Phar::__construct(): wrong number of parameters by refl… [WIP] Fix Bug #74386Phar::__construct(): wrong number of parameters by refl… May 6, 2017

@villfa villfa changed the title [WIP] Fix Bug #74386Phar::__construct(): wrong number of parameters by refl… Fix Bug #74386Phar::__construct(): wrong number of parameters by reflection May 6, 2017

@villfa villfa changed the title Fix Bug #74386Phar::__construct(): wrong number of parameters by reflection Fix Bug #74386 Phar::__construct(): wrong number of parameters by reflection May 6, 2017

@krakjoe krakjoe added the Bugfix label May 8, 2017

@krakjoe

This comment has been minimized.

Copy link
Member

commented May 8, 2017

I think this should target 7.0, but does not apply cleanly there.

@krakjoe krakjoe self-assigned this May 8, 2017

@villfa

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2017

@krakjoe I could make another PR targeting 7.0 (without modifying this one). Is it the right way to do?

@krakjoe

This comment has been minimized.

Copy link
Member

commented May 9, 2017

That would be fine

@villfa

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2017

@krakjoe I created #2519 for PHP-7.0

@krakjoe

This comment has been minimized.

Copy link
Member

commented May 29, 2017

Merged d6922ef

Thanks.

@krakjoe krakjoe closed this May 29, 2017

@villfa villfa deleted the villfa:fix_74386 branch Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.