Fix #74607 - Don't check for bi-directional compatibility in traits #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
May 24, 2017
| @@ -1154,8 +1154,8 @@ static void zend_add_trait_method(zend_class_entry *ce, const char *name, zend_s | |||
| /* Make sure the abstract declaration is compatible with previous declaration */ | |||
There was a problem hiding this comment.
Due to this else if, are we not going to miss a check in a case like this?
abstract class A {
abstract function foo($x);
}
trait T {
abstract function foo($x = 0);
}
abstract class C extends A {
use T;
}Assuming I'm understanding the desired behavior correctly (that is, abstract methods in traits impose an additional constraint, they do not simply override), this should fail, right?
There was a problem hiding this comment.
But no, that doesn't really make sense to me. Allowing that code should be fine.
|
Can we get an update on the status of this patch please ? |
|
Merged as c6c1e75 into master. Not applying this to release branches, as this is a larger change to inheritance semantics. |
|
Hi guys! Sorry for the long silence. Thanks for picking it up! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link for bugsnet: https://bugs.php.net/bug.php?id=74607
Bi-directional checks are kept in case two abstract methods are being added. Additionally, some error messages now show the proper direction of the compatibility mismatch.
Given that this lifts a current restriction, no BC breaks should be introduced.