Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

bug #46439 - better handling of CURL file uploads #255

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

smalyshev commented Jan 7, 2013

Implementation of CurlFile RFC - please see https://wiki.php.net/rfc/curl-file-upload. Can be amended following discussion on the list.

TSRMLS_CC missing here

Contributor

weltling commented Jan 7, 2013

After testing on windows i've made everything into a patch http://belsky.info/phpz/pulls/stas_46439.patch . Especially it regards to the PHPAPI macros usage as it evals to the __declspec(dllimport) and that's not what the code expected to do. Of course curl_CURLFile_class could be defined just locally if it wouldn't need to be exported. Tests pass though with this small tweaks.

Suggesting a small wording change here:

"The usage of the @filename API for file uploading is deprecated. Please use the CURLFile class instead."

Contributor

smalyshev commented Jan 8, 2013

@weltling thanks, merged.

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Jan 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment