Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #74699 - Missing range for FILTER_FLAG_NO_RES_RANGE #2562

Closed
wants to merge 1 commit into from

Conversation

@andrewnester
Copy link
Contributor

commented Jun 7, 2017

Fix for https://bugs.php.net/bug.php?id=74699

According to IPv4 Multicast Address Space Registry (https://www.iana.org/assignments/multicast-addresses/multicast-addresses.xhtml) IP addresses 224.0.0.0 – 224.0.0.255 are reserved

@andrewnester andrewnester force-pushed the andrewnester:74699-filter branch from 4367120 to 4a0172c Jun 7, 2017
@tpunt

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2017

This behaviour appears to affect later versions of PHP 7.0 too (see 3v4l), so this PR should target the PHP-7.0 branch.

@andrewnester andrewnester force-pushed the andrewnester:74699-filter branch from 4a0172c to e3268f8 Jun 7, 2017
@andrewnester andrewnester changed the base branch from PHP-7.1 to PHP-7.0 Jun 7, 2017
@andrewnester

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2017

@tpunt Thanks! just retargeted my PR to PHP-7.0 branch

@nikic

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

There seems to be some disagreement as to whether or not this is reserved?

@andrewnester

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2017

@nikic I would say that it's better to follow Multicast Address specification in this case. But I suspect that it requires some discussion anyway

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jun 13, 2017

Could you start that discussion on internals and link back to it here please.

@andrewnester

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2017

@krakjoe here is link to started discussion
http://news.php.net/php.internals/99510

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jul 10, 2017

@andrewnester bump the discussion on internals, I would ...

@bwoebi @kelunik @DaveRandom do input please

@bwoebi

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2017

Either we ban the whole block of 224.0.0.0/4 because multicast-reserved, or not at all.

At least we do not ban other strictly local net ranges like 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16, where RFC 1918 specifies as well that routers should not propagate the address into the public internet; the same restriction this very range also has.

This function seems to generally only apply to addresses reserved for link-local endpoints.
So, I'd say, we should reject this PR, in order to remain consistent with current behavior.

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Based on the rejection by a member of the group and the fact there has been no activity on this PR or discussion for a long time, I'm going to close this PR.

If I'm wrong to do that, please open a fresh PR and bump that discussion on internals.

@krakjoe krakjoe closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.