Skip to content

Fixes bug #74705 Wrong ReflectionInfo for Collator::getSortKey() #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre changed the base branch from master to PHP-7.0 June 8, 2017 04:56
@remicollet
Copy link
Member

  • This fix the getSortKey issue, but not the collator_get_sort_key one
  • skip line is not needed
  • test is failing
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Bug #74705 Wrong reflection on Collator::getSortKey [ext/intl/tests/bug74705.phpt]
=====================================================================
$ cat ext/intl/tests/bug74705.diff
003+ int(3)
004+ int(3)
003- int(2)
004- int(2)

Can you please also use normalized commit message (Fix bug #...) so bug is auto-close on merge.

I will take care of missing part

@remicollet
Copy link
Member

Merged
5f07a89
78970d5
c4d7cfa

@TysonAndre please close this

@TysonAndre TysonAndre closed this Jun 13, 2017
@TysonAndre TysonAndre deleted the fix-collator-getSortKey branch June 13, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants