Fixes bug #74708 reflection signatures for random_bytes+random_int #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have 1 and 2 required parameters, respectively See https://secure.php.net/manual/en/function.random-int.php
|
@TysonAndre I guess it should target PHP-7.0 as well, am I right? |
|
Indeed, should go in 7.0 |
|
Thanks, merged @TysonAndre you can probably close it yourself |
|
Please feel free to not add tests when fixing arginfo -- it's one of those cases where if the implementation becomes wrong (e.g. due to added parameters), the test will not help to catch that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have 1 and 2 required parameters, respectively
See https://secure.php.net/manual/en/function.random-int.php