fixes bug #65657, ISO-8601 compliant periods being rejected by parser #2598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of the parser code is pretty dodgy, and doesn't appear to be using re2c to good advantage, but I focused on fixing the immediate problem with minimal coding changes. I added a test for the bug, verified that it failed before I started coding, and now it passes on both x86_64 and ppc64le virtual hosts.
there is no Makefile rule for creating ext/date/lib/parse_iso_intervals.c from its corresponding
.re
file, so I ranre2c --no-generation-date -b -o ext/date/lib/parse_iso_intervals.c ext/date/lib/parse_iso_intervals.re
. perhaps a rule should be added to Makefile.frag, but I didn't want to dig into how that whole thing works and would rather not step on toes. DRY would suggest having only the.re
files in the repository if the.c
files are generated from them.