Implemented Feature #60524 (sys_temp_dir) #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -731,6 +731,10 @@ user_dir = | |||
| ; On windows: | |||
| ; extension_dir = "ext" | |||
|
|
|||
| ; Directory where the temporary files should be placed. | |||
| ; Defaults to the system defaut (see sys_get_temp_dir) | |||
|
Nice patch. See my few remarks and we need a test for it. Could you add one? |
|
would you like a test like this? --EXPECT-- (if yes, update my branch, right? - I'm new too this stuff) |
|
Yep, looks good. |
| { | ||
| char *system_tmp_dir = PG(system_tmp_dir); | ||
| if (system_tmp_dir) { | ||
| int len = strlen(system_tmp_dir); |
There was a problem hiding this comment.
Declarations need to be on top of the block so that our Windows build doesn’t fail
There was a problem hiding this comment.
it's okey, it at the beginning of a block
There was a problem hiding this comment.
Ah, @laruence is right. Stupid me.
Added a new configuration directive which allows it to change the temporary directory, the default behavior is unchanged. This is a useful option if you use all/some hosts inside of one .ini file with sections and want to change the temp dir per user (maybe it's not allowed to write outside the users home directory). Since the TMPDIR variable affects the whole php that way can not be used for this scenario. (see https://bugs.php.net/bug.php?id=60524)
|
Comment on behalf of stas at php.net: merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new configuration directive which allows it to change the
temporary directory, the default behavior is unchanged.
This is a useful option if you use all/some hosts inside of one .ini file
with sections and want to change the temp dir per user (maybe it's not
allowed to write outside the users home directory). Since the TMPDIR
variable affects the whole php that way can not be used for this scenario.
(see https://bugs.php.net/bug.php?id=60524)