Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug #74906 - redirecting incorrect include <sys/errno.h> #2626

Closed
wants to merge 1 commit into from

Conversation

2 participants
@petk
Copy link
Member

commented Jul 11, 2017

Hello, when compiling PHP on Alpine Linux, there appears a warning:

In file included from /build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c:51:0:
/usr/include/sys/errno.h:1:2: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp]
 #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
  ^~~~~~~
/build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c: In function 'zm_startup_snmp':
/build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c:2328:34: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
  php_snmp_object_handlers.get_gc = php_snmp_get_gc;

This patch fixes bug 74906 where more info is provided.

@krakjoe krakjoe added the Quickfix label Jul 12, 2017

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

This merges cleanly in 7.0 and 7.1, but master there is a conflict, please would you have a look at that as I'm not confident about resolving it myself ?

@krakjoe krakjoe self-assigned this Jul 12, 2017

@petk

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2017

Yes, probably because there is a commit made in master branch on that file after the PHP-7.0 and PHP-7.1 branches.

Should I open a separate pull request for the master branch?

@petk

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2017

Master branch had multiple changes in that file since, so I've made above separate pull request for master branch only instead...

@krakjoe

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

Merged 4d08b9d

Thanks.

@krakjoe krakjoe closed this Jul 17, 2017

@petk petk deleted the petk:patch-errno branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.