Skip to content

Conversation

petk
Copy link
Member

@petk petk commented Jul 11, 2017

Hello, when compiling PHP on Alpine Linux, there appears a warning:

In file included from /build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c:51:0:
/usr/include/sys/errno.h:1:2: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp]
 #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
  ^~~~~~~
/build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c: In function 'zm_startup_snmp':
/build/main/php7.2/src/php-7.2.0alpha3/ext/snmp/snmp.c:2328:34: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
  php_snmp_object_handlers.get_gc = php_snmp_get_gc;

This patch fixes bug 74906 where more info is provided.

@krakjoe
Copy link
Member

krakjoe commented Jul 12, 2017

This merges cleanly in 7.0 and 7.1, but master there is a conflict, please would you have a look at that as I'm not confident about resolving it myself ?

@krakjoe krakjoe self-assigned this Jul 12, 2017
@petk
Copy link
Member Author

petk commented Jul 12, 2017

Yes, probably because there is a commit made in master branch on that file after the PHP-7.0 and PHP-7.1 branches.

Should I open a separate pull request for the master branch?

@petk
Copy link
Member Author

petk commented Jul 12, 2017

Master branch had multiple changes in that file since, so I've made above separate pull request for master branch only instead...

@krakjoe
Copy link
Member

krakjoe commented Jul 17, 2017

Merged 4d08b9d

Thanks.

@krakjoe krakjoe closed this Jul 17, 2017
@petk petk deleted the patch-errno branch July 17, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants