Skip to content

Fixed #74977 - Appending AppendIterator leads to segfault #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed #74977 - Appending AppendIterator leads to segfault #2651

wants to merge 1 commit into from

Conversation

andrewnester
Copy link
Contributor

@krakjoe krakjoe added the Bug label Jul 24, 2017
@krakjoe
Copy link
Member

krakjoe commented Jul 25, 2017

Merged dbc2ffb

Thanks.

@krakjoe krakjoe closed this Jul 25, 2017
@nikic
Copy link
Member

nikic commented Jul 25, 2017

I don't think this fix is correct. At the very least it changes the semantics of what this method does when an AppendIterator is appended (it will now use the state of the AppendIterator at the time of the append, rather than at the time of the iteration).

@andrewnester
Copy link
Contributor Author

@nikic thanks for your comment. it was done intentionally (I mean using that of iterator at the moment of append). what could be more preferred way in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewnester @krakjoe @nikic