Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #74977 - Appending AppendIterator leads to segfault #2651

Closed
wants to merge 1 commit into from

Conversation

@andrewnester
Copy link
Contributor

andrewnester commented Jul 24, 2017

@krakjoe krakjoe added the Bugfix label Jul 24, 2017
@krakjoe

This comment has been minimized.

Copy link
Member

krakjoe commented Jul 25, 2017

Merged dbc2ffb

Thanks.

@krakjoe krakjoe closed this Jul 25, 2017
@nikic

This comment has been minimized.

Copy link
Member

nikic commented Jul 25, 2017

I don't think this fix is correct. At the very least it changes the semantics of what this method does when an AppendIterator is appended (it will now use the state of the AppendIterator at the time of the append, rather than at the time of the iteration).

@andrewnester

This comment has been minimized.

Copy link
Contributor Author

andrewnester commented Jul 25, 2017

@nikic thanks for your comment. it was done intentionally (I mean using that of iterator at the moment of append). what could be more preferred way in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.