Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed #74977 - Appending AppendIterator leads to segfault #2651
Conversation
This comment has been minimized.
This comment has been minimized.
|
Merged dbc2ffb Thanks. |
This comment has been minimized.
This comment has been minimized.
|
I don't think this fix is correct. At the very least it changes the semantics of what this method does when an AppendIterator is appended (it will now use the state of the AppendIterator at the time of the append, rather than at the time of the iteration). |
This comment has been minimized.
This comment has been minimized.
|
@nikic thanks for your comment. it was done intentionally (I mean using that of iterator at the moment of append). what could be more preferred way in this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
andrewnester commentedJul 24, 2017
Bug fix for https://bugs.php.net/bug.php?id=74977