Skip to content

Conversation

danielbeardsley
Copy link
Contributor

PDO's getColumnMeta() wasn't returning native_type for BIT, TINYINT and YEAR.

Manually tested, and updated the tests that have always been disabled.

smalyshev and others added 3 commits February 29, 2012 07:25
PDO's getColumnMeta() doesn't return native_type for BIT, TINYINT and YEAR
The test has always been disabled... so it's never run anyway. Oh well.
@smalyshev
Copy link
Contributor

This patch needs a test.

@danielbeardsley
Copy link
Contributor Author

The existing tests have been modified to account for this change, though they have been and still remain disabled.

@smalyshev
Copy link
Contributor

The test fails for me with this:

Testing native PS...
[620 + 6] Expecting native type array (
  0 => 'ENUM',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 3,
  'precision' => 0,
)
[630 + 6] Expecting native type array (
  0 => 'SET',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 6,
  'precision' => 0,
)
done!

@smalyshev
Copy link
Contributor

If I remove the ENUM/SET test changes, test passes just fine. So I think I'll merge without this change, @danielbeardsley - please see what is happening there.

@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants