Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PDO mysql meta type (fix bug #48724) #271

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

danielbeardsley commented Feb 6, 2013

PDO's getColumnMeta() wasn't returning native_type for BIT, TINYINT and YEAR.

Manually tested, and updated the tests that have always been disabled.

smalyshev and others added some commits Feb 29, 2012

@smalyshev smalyshev 5.4.0 76b580d
@tony2001 @marczych tony2001 fix bug #48724
PDO's getColumnMeta() doesn't return native_type for BIT, TINYINT and YEAR
43a652d
@danielbeardsley danielbeardsley Tests: PDO Mysql - update for fixed getColumnMeta()
The test has always been disabled... so it's never run anyway. Oh well.
5ff4d7b
Contributor

smalyshev commented Jun 16, 2013

This patch needs a test.

Contributor

danielbeardsley commented Jun 17, 2013

The existing tests have been modified to account for this change, though they have been and still remain disabled.

Contributor

smalyshev commented Jun 17, 2013

The test fails for me with this:

Testing native PS...
[620 + 6] Expecting native type array (
  0 => 'ENUM',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 3,
  'precision' => 0,
)
[630 + 6] Expecting native type array (
  0 => 'SET',
), array (
  'native_type' => 'STRING',
  'pdo_type' => 2,
  'flags' =>
  array (
  ),
  'table' => 'test',
  'name' => 'label',
  'len' => 6,
  'precision' => 0,
)
done!
Contributor

smalyshev commented Jun 17, 2013

If I remove the ENUM/SET test changes, test passes just fine. So I think I'll merge without this change, @danielbeardsley - please see what is happening there.

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Jun 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment