Skip to content

Fix LDAP path lookup on 64-bit distros #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Sep 13, 2017

ldap.h is in /usr/include on e.g. Ubuntu, but libldap.so and friends are in /usr/lib/x86_64-linux-gnu.

Not sure if it makes sense to do it for all if branches. Definitely not for libldap.3.dylib as that's macOS.

Inspired by 60aff0b (although there it's for the include dir and not the lib dir).

Fixes https://bugs.php.net/bug.php?id=49876

@dzuelke
Copy link
Contributor Author

dzuelke commented Sep 14, 2017

Commit amended with a few corrections. Good to go for merge now, @krakjoe (fix applies to 7.0 and 7.2 as well).

@dzuelke
Copy link
Contributor Author

dzuelke commented Oct 17, 2017

@krakjoe Y U NO MERGE? ;)

ldap.h is in /usr/include on e.g. Ubuntu, but libldap.so and friends are in /usr/lib/x86_64-linux-gnu

Fixes https://bugs.php.net/bug.php?id=49876
@dzuelke
Copy link
Contributor Author

dzuelke commented Nov 21, 2017

Freshly rebased and all tests green. @krakjoe ? :)

@krakjoe
Copy link
Member

krakjoe commented Feb 8, 2018

Merged 8000334

Thanks

(sorry about the delay)

@krakjoe krakjoe closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants