Skip to content

Fix bug #69954 and remove pdo_mysql.cache_size INI directive #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Sep 26, 2017

This patch removes the pdo_mysql.cache_size ini directive which has been
removed since PHP 5.3.0 due to a bug

Found here.

There are also some URLs synced with this PR to fix bug #69954

@nikic
Copy link
Member

nikic commented Sep 26, 2017

There is also a mysqli.cache_size option, which also looks unused.

@petk
Copy link
Member Author

petk commented Sep 26, 2017

Yes, that has been also removed since then. The mysqli.cache_size directive is now also removed and the two commits have been rebased.

@krakjoe krakjoe added the Bug label Sep 27, 2017
…INI directives

This patch removes some non working links to PHP manual and removes the
pdo_mysql.cache_size and mysqli.cache_size INI directives which have been
removed since PHP 5.3.0.
@petk
Copy link
Member Author

petk commented Oct 17, 2017

Hello, there were some more changes added to this pull request.

So overall: instead of patching the PHP.net site and adjusting the redirects to the manual pages, I would suggest to simply remove the non working links instead and have the reader find those pages themselves. Besides currently there are many PHP ini directives in these files without links to the manual. All changes are mentioned in the commit message. Thanks for checking this out.

@krakjoe
Copy link
Member

krakjoe commented Oct 23, 2017

Merged 14609ca

Thanks.

@krakjoe krakjoe closed this Oct 23, 2017
@petk petk deleted the patch-ini branch October 23, 2017 09:28
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Jan 7, 2018
…hile. This patch removes it from the manual, since it is not used in the PHP core since 5.3.0 version

php/php-src#2777

-- 
Provided by anonymous 80662 (peterkokot@gmail.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343775 c90b9560-bf6c-de11-be94-00142212c4b1
LawnGnome pushed a commit to LawnGnome/phpdoc-en that referenced this pull request Jan 7, 2018
…hile. This patch removes it from the manual, since it is not used in the PHP core since 5.3.0 version

php/php-src#2777

-- 
Provided by anonymous 80662 (peterkokot@gmail.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343775 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github pushed a commit to svn2github/phpdoc_en that referenced this pull request Jan 8, 2018
…hile. This patch removes it from the manual, since it is not used in the PHP core since 5.3.0 version

php/php-src#2777

-- 
Provided by anonymous 80662 (peterkokot@gmail.com)

git-svn-id: http://svn.php.net/repository/phpdoc/en@343775 c90b9560-bf6c-de11-be94-00142212c4b1
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Sep 3, 2020
…hile. This patch removes it from the manual, since it is not used in the PHP core since 5.3.0 version

php/php-src#2777

-- 
Provided by anonymous 80662 (peterkokot@gmail.com)

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@343775 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants