Skip to content

Conversation

ramsey
Copy link
Member

@ramsey ramsey commented Sep 28, 2017

This contains four test files to assert expected behavior:

  1. This test currently fails, as it is asserting the expected behavior reported by the bug; it uses XFAIL for now
  2. through 4. Asserts behavior that currently works as expected; added to ensure completeness of tests

This contains four test files to assert expected behavior:

1.   This test currently fails, as it is asserting the expected
     behavior reported by the bug; it uses XFAIL for now
2-4. Asserts behavior that currently works as expected; added to ensure
     completeness of tests
@ramsey
Copy link
Member Author

ramsey commented Sep 29, 2017

Discussed with @sgolemon on Twitter, who suggested that this might need an RFC:

Well... the behavior is pretty established. I'd say changing the behavior requires an RFC, especially as there is a workaround.

I'll start a thread on internals and see what others think. If it needs to go that route, I'll create an RFC.

@krakjoe
Copy link
Member

krakjoe commented Oct 3, 2017

New tests target master only please.

@ramsey
Copy link
Member Author

ramsey commented Oct 3, 2017

I'm going to close this. It sounds like it needs an RFC. Thanks!

@ramsey ramsey closed this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants