[PHP 7.2] Fix bug #75279 #2788
Merged
[PHP 7.2] Fix bug #75279 #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laruence
reviewed
Sep 29, 2017
ext/standard/dl.c
Outdated
| @@ -110,7 +110,7 @@ PHPAPI int php_load_extension(char *filename, int type, int start_now) | |||
| char *libpath; | |||
| zend_module_entry *module_entry; | |||
| zend_module_entry *(*get_module)(void); | |||
| int error_type, slash_suffix = NULL; | |||
| int error_type, slash_suffix; | |||
There was a problem hiding this comment.
I think this change will cause line 154 may use of uninitialized value, should be change to slash_suffix=0
There was a problem hiding this comment.
Done. Then it should be added to master branch also (I've updated above message to target both branches. Thanks.
petk
force-pushed
the
patch-compile-warning
branch
from
751716f to
8d87f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixed bug #75279 and it's for PHP-7.2 and master branches. Related to 4fbff82