Skip to content

Conversation

petk
Copy link
Member

@petk petk commented Oct 5, 2017

Hello, here are few more refactorings of the README.md file inspired from other open source projects and the Art of README:

  • added a short description of the php-src repository
  • links to Git repository and GitHub mirror are refactored to suit more use cases (when browsing the README.md file from download release archive)
  • INSTALL and README.WIN32-BUILD-SYSTEM seem redundant and the PHP manual installation chapter has been mentioned in the README.md installation section instead.
  • links have been put in the text without using Markdown links for now, to be more readable in text editors.

@KalleZ
Copy link
Member

KalleZ commented Oct 5, 2017

Maybe we should also kill the install file from the win32 directory in this pr

@petk
Copy link
Member Author

petk commented Oct 6, 2017

Yes, in branches PHP-7.2, PHP-7.1... there are INSTALL and win32/install.txt files that are generated from the phpdoc repository. In the master branch the win32/install.txt file is removed from Git.

Also the INSTALL file is used by the win32/build/makedist.php script, which seems to be manually adjusted when releasing the win download archive. That's slightly beyond my understanding yet.

I would need some more pointers here regarding these files. Basically the INSTALL or install.txt are OK to be added to the release archives for reading offline if they are updated, but from the repository point of view they cause confusion.

I think a simplest and most future prone solution would be to have a single entry place php.net/install for all installation information everywhere - in the Git repository and the release archives when downloading PHP. And the installation link added to the README.md (and maybe README.txt for windows environment in case .md file types are arcane on this platform).

@petk
Copy link
Member Author

petk commented Oct 6, 2017

But I think I understand what's going on here. Sorry for above confusion. Basically all this has already been thought through and set for master branch using only a single INSTALL file. What about the following?

  • README.md includes PHP intro, installation link pointing to php.net/install and contributing information
  • Windows archive release gets also a README.md attached instead of the install.txt

README.md file now includes short description of the php-src repository,
some links to Git repository and GitHub mirror and short installation
information.

When creating windows builds, instead of the install.txt file the
README.md file is attached instead.

Update windows makedist script
@petk
Copy link
Member Author

petk commented Oct 9, 2017

A minor update: this pull request now includes the following changes as discussed above:

  • README.md file includes the installation information and php-src description with Git repository and GitHub mirror locations
  • README.WIN32-BUILD-SYSTEM file is removed in favor of the links provided at php.net/install
  • win32/build/makedist.php script attaches the README.md file instead of the previous install.txt

Commits are squashed into a single one. This is also related to pull request #2792 which will be synced later on to avoid confusions. Thanks...

@petk
Copy link
Member Author

petk commented Oct 9, 2017

I'll join two pull requests into one instead for easier understanding of the whole. Closing this pull request in favor of a new one...

@petk petk closed this Oct 9, 2017
@petk petk deleted the patch-readme branch October 20, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants