allow CURLOPT_INFILE to be reset #283
Conversation
…ULL to reset INFILE to default, unless the read-function is a user callback Closes bug #64247 and #44866
|
Could you add some tests please? |
|
Should I just test if setting CURLOPT_INFILE to NULL fails? |
|
In #64247 you've posted a scenario description, that's what should be tested I think. There is also a repro code you gave under http://pastebin.com/XLJsZ9JH which can be converted to a phpt. The built-in cli server might be helpful for that, just take a look at sapi/cli/tests/php_cli_server*phpt |
|
The problem is that one can only test if setting to NULL failed, but not what really happens in the "underworld" of interface.c, as there is no get-method available for the CURL options. |
|
That's true, you can only test whether the php code works as expected and php don't crash and valgrind is happy. If that all is given one can expect the backend c code is correct. The better phpt is, the more the expectation is fulfilled. |
|
Okay will do so :) |
|
@msmuenchen ping ) |
|
Looks like it's fixed by 54fee59 |
|
Comment on behalf of tyrael at php.net: implemented in http://git.php.net/?p=php-src.git;a=commit;h=54fee59598082052395f4011931096babd6f4013 |
This allows CURLOPT_INFILE to be reset to defaults without resetting the rest of the CURL object.
Closes bug #64247 and #44866